Dan Yasny has posted comments on this change. Change subject: Cisco VM-FEX support vdsm hooks ......................................................................
Patch Set 9: (3 inline comments) .................................................... File vdsm_hooks/vmfex/before_vm_migrate_destination.py Line 7: #3.0 compat Line 8: import libvirtconnection Line 9: except ImportError: Line 10: #3.1 compat Line 11: from vdsm import libvirtconnection ideas? https://github.com/kevinw/pyflakes/issues/13 and http://stackoverflow.com/questions/5033727/how-do-i-get-pyflakes-to-ignore-a-statement pretty much provide the same idea and state this is a pyflakes bug Line 12: import fcntl Line 13: from xml.dom import minidom Line 14: Line 15: ''' .................................................... File vdsm_hooks/vmfex/before_vm_start.py Line 92: # Example ['eth0','eth1'] Line 93: nics = [] Line 94: for root, dirs, names in os.walk('/sys/devices/'): Line 95: if 'address' in names and 'pci' in root: Line 96: f = open(root + '/address', 'r') You're right, gotta fix that (it's your code I copied after all) Line 97: mac = f.readlines()[0].strip() Line 98: f.close() Line 99: if mac == '00:00:00:00:00:00': Line 100: eth = root.split('/')[-1] Line 158: else: Line 159: return False Line 160: Line 161: Line 162: def handleDirectPool(conn): I'd rather leave it for now, until vdsm takes the hook under it's wing and makes everything right Line 163: #TODO: take this part and everything it uses out and into a separate Line 164: # module Line 165: Line 166: #is direct-pool defined? If not, just create it and move on -- To view, visit http://gerrit.ovirt.org/7547 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I45a7fa46919bb39a648dff190c40618395990e91 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Yasny <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Dan Yasny <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Igor Lvovsky <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
