Dan Kenigsberg has posted comments on this change.
Change subject: Cisco VM-FEX support vdsm hooks
......................................................................
Patch Set 12: I would prefer that you didn't submit this
(2 inline comments)
....................................................
File vdsm_hooks/vmfex/before_vm_migrate_destination.py
Line 95: dpool.create()
Line 96: sys.stderr.write('vmfex: created Direct-Pool Net \n')
Line 97: sys.stderr.write(xmlstr + '\n')
Line 98: except: # Need a traceback on ANY error, thus no specification
Line 99: sys.stderr.write('vmfex: Failed createDirectPool \n')
I don't understand why you've added this try-block. The write() at the end of
this file already catches and prints this traceback.
If your point here was to ignore various libvirt errors - go ahead an enumerate
them. Catch-all "except" is dangerous - if the pool was not created, you don't
want to go on starting the VM.
Line 100: sys.stderr.write('vmfex: ERROR: %s\n' %
traceback.format_exc())
Line 101: finally:
Line 102: fcntl.flock(f.fileno(), fcntl.LOCK_UN)
Line 103:
Line 98: except: # Need a traceback on ANY error, thus no specification
Line 99: sys.stderr.write('vmfex: Failed createDirectPool \n')
Line 100: sys.stderr.write('vmfex: ERROR: %s\n' %
traceback.format_exc())
Line 101: finally:
Line 102: fcntl.flock(f.fileno(), fcntl.LOCK_UN)
this is wrong here, as "f" may not be defined here. it was correct in the
former patch.
Line 103:
Line 104:
Line 105: def qbhInUse(conn):
Line 106: for vm in conn.listDomainsID():
--
To view, visit http://gerrit.ovirt.org/7547
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I45a7fa46919bb39a648dff190c40618395990e91
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Yasny <[email protected]>
Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Dan Yasny <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Igor Lvovsky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
