Nir Soffer has posted comments on this change. Change subject: mount: Perform mount and umount in supervdsm ......................................................................
Patch Set 7: (2 comments) https://gerrit.ovirt.org/#/c/43969/7//COMMIT_MSG Commit Message: Line 6: Line 7: mount: Perform mount and umount in supervdsm Line 8: Line 9: We used to run the mount and umount commands using sudo, which requires Line 10: error prone sudoers configuration, and allows any process running as > allow Done Line 11: vdsm (e.g. a vdsm hook) to perform commands, instead of only vdsmd Line 12: daemon itself. Line 13: Line 14: This patch changes Mount class to perform mount and umount using Line 15: supervdsm, and remove the now unneeded sudoers configuration for mount, Line 16: umount, and systemd-run. Line 17: Line 18: Since mounting requires running supervdsm now, tests that used to check Line 19: for that mount works using sudo require now root, and mount module is > work Done Line 20: using supervdsm only if not running as root. Line 21: Line 22: Change-Id: I38fb0eed0ba3e2c36aba8ca4ec262032cb012fc2 -- To view, visit https://gerrit.ovirt.org/43969 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I38fb0eed0ba3e2c36aba8ca4ec262032cb012fc2 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Dima Kuznetsov <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
