Nir Soffer has submitted this change and it was merged. Change subject: mount: Perform mount and umount in supervdsm ......................................................................
mount: Perform mount and umount in supervdsm We used to run the mount and umount commands using sudo, which requires error prone sudoers configuration, and allow any process running as vdsm (e.g. a vdsm hook) to perform commands, instead of only vdsmd daemon itself. This patch changes Mount class to perform mount and umount using supervdsm, and remove the now unneeded sudoers configuration for mount, umount, and systemd-run. Since mounting requires running supervdsm now, tests that used to check for that mount work using sudo require now root, and mount module is using supervdsm only if not running as root. Change-Id: I38fb0eed0ba3e2c36aba8ca4ec262032cb012fc2 Signed-off-by: Nir Soffer <[email protected]> Reviewed-on: https://gerrit.ovirt.org/43969 Continuous-Integration: Jenkins CI Reviewed-by: Freddy Rolland <[email protected]> Reviewed-by: Piotr Kliczewski <[email protected]> Reviewed-by: Adam Litke <[email protected]> --- M lib/vdsm/storage/mount.py M tests/mkimageTests.py M tests/mountTests.py M vdsm/sudoers.vdsm.in M vdsm/supervdsmServer 5 files changed, 83 insertions(+), 53 deletions(-) Approvals: Piotr Kliczewski: Looks good to me, but someone else must approve Adam Litke: Looks good to me, approved Nir Soffer: Verified Jenkins CI: Passed CI tests Freddy Rolland: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/43969 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I38fb0eed0ba3e2c36aba8ca4ec262032cb012fc2 Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Dima Kuznetsov <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Freddy Rolland <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
