Nir Soffer has posted comments on this change. Change subject: mount: Log info message when mounting or unmounting ......................................................................
Patch Set 6: (1 comment) https://gerrit.ovirt.org/#/c/43974/6/vdsm/storage/mount.py File vdsm/storage/mount.py: Line 216: return hash((self.__class__, self.fs_spec, self.fs_file)) Line 217: Line 218: def mount(self, mntOpts=None, vfstype=None, timeout=None, cgroup=None): Line 219: self.log.info("mounting %s at %s", self.fs_spec, self.fs_file) Line 220: with utils.stopwatch("%s mounted" % self.fs_file, log=self.log): > with block in both methods looks very similar. Is there a way to make them Every line here differ: - mount vs umount when checking if running as root - log message - command arguments I don't think we should try to abstract things it will only make the code hard to understand. Line 221: if os.geteuid() != 0: Line 222: mount = supervdsm.getProxy().mount Line 223: else: Line 224: mount = _mount -- To view, visit https://gerrit.ovirt.org/43974 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idc89d6a1bfa0e9d117344d8870d81fed140d03c6 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Ala Hino <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Freddy Rolland <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
