Adam Litke has posted comments on this change. Change subject: qemuimg: Make QCOW2_COMPAT configurable ......................................................................
Patch Set 2: (1 comment) -1 for visibility. Let's address my comment before proceeding please. https://gerrit.ovirt.org/#/c/54759/2/lib/vdsm/qemuimg.py File lib/vdsm/qemuimg.py: Line 129 Line 130 Line 131 Line 132 Line 133 I think we should validate this setting against a list of approved values. This would provide several benefits: We can document the ones we accept. We can prevent the user from making a mistake when setting this. Since we are feeding this value directly into the arguments list of a command we're calling, we can make sure the value used is safe. I realize it means we need to maintain this list over time, but I think it's good for us to check new compat versions to see if we're ready to allow them to be used in vdsm storage. -- To view, visit https://gerrit.ovirt.org/54759 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5272171a4b4931698911ab251e3a34c286908be4 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Ala Hino <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Freddy Rolland <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Pavel Gashev <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: Yaniv Kaul <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
