Nir Soffer has posted comments on this change. Change subject: qemuimg: Make QCOW2_COMPAT configurable ......................................................................
Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/54759/2/lib/vdsm/qemuimg.py File lib/vdsm/qemuimg.py: Line 129 Line 130 Line 131 Line 132 Line 133 > I think we should validate this setting against a list of approved values. I agree, this should be easy: SUPPORTED_QCOW2_COMPAT = ["0.10", "1.1"] And raise if the current configuration is not supported. This should be done on startup when reading the configuration file, but we don't have the infrastructure for this now. Pavel, what do you think? -- To view, visit https://gerrit.ovirt.org/54759 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5272171a4b4931698911ab251e3a34c286908be4 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Ala Hino <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Freddy Rolland <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Pavel Gashev <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: Yaniv Kaul <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
