Francesco Romani has posted comments on this change. Change subject: migration: move helper into Progress class ......................................................................
Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/56313/2/vdsm/virt/migration.py File vdsm/virt/migration.py: PS2, Line 711: > (not familiar enough with the code) Why do we check this? (also below) Back in time we had some nasty cases on which libvirt reported 0 (IIRC at the end of the migration), so we are being defensive here - and not, we didn't found a good reproducer to file a libvirt bug. -- To view, visit https://gerrit.ovirt.org/56313 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If8e5a5cdf2249d73ef45c4f50e1fa6c4338ad8a0 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <[email protected]> Gerrit-Reviewer: Milan Zamazal <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
