Francesco Romani has posted comments on this change. Change subject: migration: move helper into Progress class ......................................................................
Patch Set 5: (1 comment) https://gerrit.ovirt.org/#/c/56313/5/tests/vmMigrationTests.py File tests/vmMigrationTests.py: PS5, Line 202: # data_remaining and data_total are both VIR_TYPED_PARAM_ULLONG : # so we cannot get negative values here > As we discussed off-gerrit, I still believe that negative tests or raising And you are just right. -- To view, visit https://gerrit.ovirt.org/56313 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If8e5a5cdf2249d73ef45c4f50e1fa6c4338ad8a0 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <mpoled...@redhat.com> Gerrit-Reviewer: Milan Zamazal <mzama...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
