Francesco Romani has posted comments on this change. Change subject: events: introduction of schema ......................................................................
Patch Set 15: Code-Review-1 (3 comments) questions inside, -1 for visibility https://gerrit.ovirt.org/#/c/54754/15/lib/api/vdsm-events.yml File lib/api/vdsm-events.yml: PS15, Line 64: StatusDetails this is an union actually, it could contain few differents _sets_ of attributes thepending on the VM status (no pun intended :)) Do we have a good way to represent this besides marking everything as optional? PS15, Line 70: *VmStatus does this mean it is optional? https://gerrit.ovirt.org/#/c/54754/15/lib/vdsm/rpc/Bridge.py File lib/vdsm/rpc/Bridge.py: Line 101: self._schema.get_method(method) Line 102: className, methodName = method.split('.', 1) Line 103: except (KeyError, ValueError): Line 104: raise yajsonrpc.JsonRpcMethodNotFoundError(method) Line 105: unrelated? Line 106: return partial(self._dynamicMethod, className, methodName) Line 107: Line 108: def _convert_class_name(self, name): Line 109: """ -- To view, visit https://gerrit.ovirt.org/54754 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I43a9f1852b1459a2e905244049507704f0187201 Gerrit-PatchSet: 15 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
