Piotr Kliczewski has posted comments on this change. Change subject: events: introduction of schema ......................................................................
Patch Set 15: (3 comments) https://gerrit.ovirt.org/#/c/54754/15/lib/api/vdsm-events.yml File lib/api/vdsm-events.yml: PS15, Line 64: StatusDetails > this is an union actually, it could contain few differents _sets_ of attrib This is the first thing that came to my mind when I saw bunch of events that were triggered by vdsm. This is not really a union due to mandatory status and some of the optional params need to be together like exit*. PS15, Line 70: *VmStatus > does this mean it is optional? No, '*' is an alias as it is understood by yaml. I base this type definition on bunch of events that I saw from live system. https://gerrit.ovirt.org/#/c/54754/15/lib/vdsm/rpc/Bridge.py File lib/vdsm/rpc/Bridge.py: Line 101: self._schema.get_method(method) Line 102: className, methodName = method.split('.', 1) Line 103: except (KeyError, ValueError): Line 104: raise yajsonrpc.JsonRpcMethodNotFoundError(method) Line 105: > unrelated? No, will remove Line 106: return partial(self._dynamicMethod, className, methodName) Line 107: Line 108: def _convert_class_name(self, name): Line 109: """ -- To view, visit https://gerrit.ovirt.org/54754 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I43a9f1852b1459a2e905244049507704f0187201 Gerrit-PatchSet: 15 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmu...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
