Nir Soffer has posted comments on this change. Change subject: Refactor metadata operations ......................................................................
Patch Set 6: (1 comment) https://gerrit.ovirt.org/#/c/52671/6/vdsm/storage/volume.py File vdsm/storage/volume.py: Line 223: DESCRIPTION_SIZE) Line 224: desc = desc[:DESCRIPTION_SIZE] Line 225: return desc Line 226: Line 227: def storage_format(self): I was happy with the previous name (format) - why change it? Line 228: """ Line 229: Format metadata string in storage format. Line 230: Line 231: Raises MetadataOverflowError if formatted metadata is too long. -- To view, visit https://gerrit.ovirt.org/52671 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4fee56b30c13a3c1cede8489338ed60f4e1d5eab Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Ala Hino <ah...@redhat.com> Gerrit-Reviewer: Freddy Rolland <froll...@redhat.com> Gerrit-Reviewer: Idan Shaby <ish...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
