Nir Soffer has posted comments on this change. Change subject: Makefile: use tox to run make pep8 and pyflakes ......................................................................
Patch Set 7: (3 comments) https://gerrit.ovirt.org/#/c/49952/7/automation/check-patch.packages.el7 File automation/check-patch.packages.el7: Line 14: python-inotify Line 15: python-ioprocess Line 16: python-netaddr Line 17: python-nose Line 18: python-tox Maybe install this via pip? Line 19: python-pthreading Line 20: python-rtslib Line 21: python-six Line 22: python34-nose https://gerrit.ovirt.org/#/c/49952/7/automation/check-patch.packages.fc23 File automation/check-patch.packages.fc23: Line 13: python-inotify Line 14: python-ioprocess Line 15: python-netaddr Line 16: python-nose Line 17: python-tox Maybe install via pip? Line 18: python-pthreading Line 19: python-six Line 20: python3-netaddr Line 21: python3-nose https://gerrit.ovirt.org/#/c/49952/7/tox.sh File tox.sh: Line 19: PEP8_BLACKLIST=(config.py \ Line 20: constants.py \ Line 21: crossImportsTests.py \ Line 22: vdsm.py \ Line 23: ) Unwanted tab Line 24: Line 25: if [ 'pyflakes' = "$1" ]; then Line 26: (find . -path './.tox' -prune -type f -o \ Line 27: -path './.git' -prune -type f -o \ -- To view, visit https://gerrit.ovirt.org/49952 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id583de2d411bb5bcd0f717f569d2961b555334c9 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Yeela Kaplan <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
