Dan Kenigsberg has posted comments on this change.
Change subject: Make netinfoTests follow closely python guidelines.
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
....................................................
File tests/netinfoTests.py
Line 37: for line in netmaskFile:
Line 38: if line.startswith('#'):
Line 39: continue
Line 40: bitmask, address = [value.strip() for value in
line.split()]
Line 41:
self.assertEqual(netinfo.bitmask_to_address(int(bitmask)), address)
but please do not break from 80 chars limitation...
Line 42:
Line 43: def testSpeedInvalidNic(self):
Line 44: nicName = 'DUMMYNICDEVNAME'
Line 45: self.assertTrue(nicName not in netinfo.nics())
--
To view, visit http://gerrit.ovirt.org/8717
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie4774eb1c89914f2bb77db3cb25d8266fcf1f060
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Igor Lvovsky <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
