Dan Kenigsberg has submitted this change and it was merged. Change subject: Make netinfoTests follow closely python guidelines. ......................................................................
Make netinfoTests follow closely python guidelines. Change 'file' by 'open' and use a with block not to wait for gc. Prefer list comprehensions to map and filter. Change-Id: Ie4774eb1c89914f2bb77db3cb25d8266fcf1f060 Signed-off-by: Antoni S. Puimedon <[email protected]> --- M tests/netinfoTests.py 1 file changed, 7 insertions(+), 5 deletions(-) Approvals: Adam Litke: Looks good to me, but someone else must approve Mark Wu: Looks good to me, but someone else must approve Dan Kenigsberg: Verified; Looks good to me, approved Igor Lvovsky: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/8717 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie4774eb1c89914f2bb77db3cb25d8266fcf1f060 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Igor Lvovsky <[email protected]> Gerrit-Reviewer: Mark Wu <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
