Nir Soffer has posted comments on this change. Change subject: mount: Add mounts monitor ......................................................................
Patch Set 4: One issue with this patch - current caching is not needed and is removed in https://gerrit.ovirt.org/56517, so I'm not sure we need to monitor mounts changes. This can replace the udevadm hack used to detect completion of a loop device umount, but waiting for mount changes is not enough, since you want to wait for specific device, and this waits only for some mount change. We can wait for specific device using pyudev.Monitor. So this can be useful only if we want to replace mounts polling with mounts events - read current mounts each time we receive an event, and serve mounts results from the cached version. I need to do profiling to see if checking mount status is still an issue with many file based storage domains. -- To view, visit https://gerrit.ovirt.org/56516 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I25ad36ebfde12d2e3250e893de98bba66f160623 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Ala Hino <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Freddy Rolland <[email protected]> Gerrit-Reviewer: Idan Shaby <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: No _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
