Nir Soffer has posted comments on this change. Change subject: mount: Add mounts monitor ......................................................................
Patch Set 4: (2 comments) This is experimental infrastructure, if we will decide to use it, I will integrate it in a following patch. https://gerrit.ovirt.org/#/c/56516/4/lib/vdsm/storage/mount.py File lib/vdsm/storage/mount.py: Line 342: monitor.wait() Line 343: Line 344: """ Line 345: Line 346: log = logging.getLogger("storage.Mount.Monitor") > Shouldn't it be "storage.Monitor"? This name belongs to storage/monitor.py Line 347: Line 348: def __init__(self, callback): Line 349: self._was_changed = callback Line 350: self._mountsfd = -1 Line 391: raise Line 392: Line 393: def wait(self, timeout=None): Line 394: """ Line 395: Wait until the monitor stops. Return True if the monitor has stooped > s/stooped/stopped Thanks, will fix. Line 396: and False if the timeout expired. Line 397: """ Line 398: self._thread.join(timeout) Line 399: return not self._thread.is_alive() -- To view, visit https://gerrit.ovirt.org/56516 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I25ad36ebfde12d2e3250e893de98bba66f160623 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Ala Hino <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Freddy Rolland <[email protected]> Gerrit-Reviewer: Idan Shaby <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
