Milan Zamazal has posted comments on this change. Change subject: virt: Set timeout on boot menu ......................................................................
Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/56393/3/lib/vdsm/config.py.in File lib/vdsm/config.py.in: Line 240: Line 241: ('boot_menu_timeout', '10', Line 242: 'Boot menu timeout in seconds. ' Line 243: 'Minimum value is 0, maximum value is 65; if a different value ' Line 244: 'is given then it is adjusted to this range.'), > Vdsm conf is not the place for this, this should be a per-vm settings contr Well, increased boot menu timeout is a feature that's not strictly needed, but it was requested and may be convenient for some users. So we can provide it but we probably don't want to pollute the Web user interface with it. We can simply hard code the 10 s value but it was suggested in the bug report to provide a Vdsm configuration option to be able to override it. Can you suggest a better solution for this situation? Line 245: ]), Line 246: Line 247: # Section: [rpc] Line 248: ('rpc', [ -- To view, visit https://gerrit.ovirt.org/56393 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0f3501e8500e366e785f5a8ddfdf78fd34c997a2 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Milan Zamazal <mzama...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <mpoled...@redhat.com> Gerrit-Reviewer: Milan Zamazal <mzama...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
