Dan Kenigsberg has posted comments on this change.
Change subject: Adding supervdsm unit tests
......................................................................
Patch Set 6: I would prefer that you didn't submit this
(2 inline comments)
....................................................
File vdsm/supervdsmServer.py
Line 41: from storage.multipath import getScsiSerial as _getScsiSerial
Line 42: from storage.iscsi import forceIScsiScan as _forceIScsiScan
Line 43: from storage.iscsi import getDevIscsiInfo as _getdeviSCSIinfo
Line 44: from storage.iscsi import readSessionInfo as _readSessionInfo
Line 45: <<<<<<< HEAD
rebase spam!
Line 46: from supervdsm import _SuperVdsmManager, PIDFILE, ADDRESS, TIMESTAMP
Line 47: =======
Line 48: from supervdsm import _SuperVdsmManager
Line 49: >>>>>>> ce5b4ed... Adding supervdsm unit tests
Line 331: log.warn("Could not init proper logging", exc_info=True)
Line 332:
Line 333: log = logging.getLogger("SuperVdsm.Server")
Line 334: try:
Line 335: address = None
the proper way to avoid the undefined variable problem is the following:
the "finally" block cleans "address". so the "try" should be placed right after
"address" socket is created.
Line 336: log.debug("Making sure I'm root")
Line 337: if os.geteuid() != 0:
Line 338: sys.exit(errno.EPERM)
Line 339:
--
To view, visit http://gerrit.ovirt.org/8600
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I08880b12db8a6ca9cc57d74d2ef2a86980a5b097
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: Adam Litke <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Saggi Mizrahi <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
