Adam Litke has posted comments on this change.
Change subject: Adding supervdsm unit tests
......................................................................
Patch Set 8: I would prefer that you didn't submit this
(2 inline comments)
....................................................
File vdsm/supervdsm.py
Line 90
Line 91
Line 92
Line 93
Line 94
Hmm, still no comments explaining why these are overrideable as I requested in
an earlier review. Please add a comment.
....................................................
File vdsm/supervdsmServer.py
Line 376:
Line 377: log.debug("Started serving super vdsm object")
Line 378: servThread.join()
Line 379: except Exception as e:
Line 380: log.error("Could not start Super Vdsm: %s", e)
You reverted to the old, undesirable exception printing method. Please keep
this bit the way it was.
Line 381: sys.exit(1)
Line 382: finally:
Line 383: try:
Line 384: if address is not None and os.path.exists(address):
--
To view, visit http://gerrit.ovirt.org/8600
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I08880b12db8a6ca9cc57d74d2ef2a86980a5b097
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: Adam Litke <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Saggi Mizrahi <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
