Shu Ming has posted comments on this change. Change subject: Fix race in fileUtils.createdir(). ......................................................................
Patch Set 1: I would prefer that you didn't submit this (1 inline comment) .................................................... File vdsm/storage/fileUtils.py Line 175: """ Line 176: DIR_BIT = 040000 Line 177: params = (dirPath, mode) if mode is not None else (dirPath,) Line 178: try: Line 179: os.makedirs(*params) I don't think os.makedirs() is an atomic operation. Inside of os.makedirs(), it calls patch.exist() first and then call makedirs(). So, it get the same issue as the original code if the issue exists. See: /usr/lib64/python2.7/os.py. Line 180: except OSError as e: Line 181: if e.errno != errno.EEXIST: Line 182: raise Line 183: else: -- To view, visit http://gerrit.ovirt.org/8732 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iac856c219a08fa0303e5da1d04f4f6b8e17e07a3 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Eduardo <[email protected]> Gerrit-Reviewer: Shu Ming <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Yeela Kaplan <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
