Adam Litke has posted comments on this change. Change subject: Fix race in fileUtils.createdir(). ......................................................................
Patch Set 3: I would prefer that you didn't submit this (1 inline comment) Good in principle. Just one style nit. .................................................... File vdsm/storage/fileUtils.py Line 190: statinfo = os.stat(dirPath) Line 191: if statinfo[stat.ST_MODE] != mode: Line 192: raise OSError(errno.EPERM, Line 193: "Existing %s dir permissions %s are not as requested %s" % Line 194: (dirPath, oct(statinfo[stat.ST_MODE]), oct(mode))) These last two lines should be indented since they are a part of the raise statement. Line 195: Line 196: Line 197: def resolveUid(user): Line 198: if isinstance(user, types.StringTypes): -- To view, visit http://gerrit.ovirt.org/8732 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iac856c219a08fa0303e5da1d04f4f6b8e17e07a3 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Eduardo <[email protected]> Gerrit-Reviewer: Shu Ming <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Yeela Kaplan <[email protected]> Gerrit-Reviewer: Zhou Zheng Sheng <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
