Milan Zamazal has posted comments on this change. Change subject: hostdev: expose parameters needed to support hotunplug ......................................................................
Patch Set 19: Code-Review+1 (1 comment) Better now. > I don't feel like adding xpath test in this patch. It is good idea for future > patch, with other devices following the trend. The trend of adding tests or the trend of postponing addition tests? ;-) https://gerrit.ovirt.org/#/c/54939/19/vdsm/virt/vmdevices/hostdevice.py File vdsm/virt/vmdevices/hostdevice.py: Line 59: return {'base': '0x', 'padding': ''} Line 60: return {'base': '0x', 'padding': '02'} Line 61: return {'base': '', 'padding': ''} Line 62: Line 63: address_format_string = '[@{key}=\'{base}{value:{padding}}\']' Why not using double quotes for the string to avoid the need of backslashes? Line 64: address = ''.join([address_format_string.format( Line 65: key=key, value=int(value), **_padding(key)) for Line 66: key, value in self.hostAddress.items()]) Line 67: -- To view, visit https://gerrit.ovirt.org/54939 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I09e879051b1d47e48e9ae73c1f7d9bfbea8f1237 Gerrit-PatchSet: 19 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik <mpoled...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <mpoled...@redhat.com> Gerrit-Reviewer: Milan Zamazal <mzama...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
