Francesco Romani has posted comments on this change. Change subject: hostdev: expose parameters needed to support hotunplug ......................................................................
Patch Set 24: Code-Review-1 (1 comment) I'm fine with the idea, but the implementation is too terse and hard to read. https://gerrit.ovirt.org/#/c/54939/24/vdsm/virt/vmdevices/hostdevice.py File vdsm/virt/vmdevices/hostdevice.py: PS24, Line 64: address = ''.join([address_format_string.format( : key=key, value=int(value), **_padding(key)) for : key, value in self.hostAddress.items()]) nope, this is still too clever. Please try to make it more explicit and more readable. -- To view, visit https://gerrit.ovirt.org/54939 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I09e879051b1d47e48e9ae73c1f7d9bfbea8f1237 Gerrit-PatchSet: 24 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik <mpoled...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <mpoled...@redhat.com> Gerrit-Reviewer: Milan Zamazal <mzama...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
