Dan Kenigsberg has submitted this change and it was merged.
Change subject: NetworkManager: configure to monitor ifcfg/connection files
......................................................................
NetworkManager: configure to monitor ifcfg/connection files
The new configuration file instructs NetworkManager to automatically
reload network configuration from the directory it uses to persist
its "connections" (one could say "profiles"):
- /etc/sysconfig/network-scripts/ in the case of ifcfg systems
(Fedora, RHEL, CentOS and derivatives; "ifcfg-rh" plugin)
- /etc/NetworkManager/system-connections/ ("keyfile" plugin)
- or another, specific to e.g. Debian or Suse
This functionality is required to properly let NetworkManager
know when VDSM consumes any of its devices (on ifcfg systems,
by writing NM_CONTROLLED=no to an ifcfg file).
Please note that this approach is potentially raceful. Under
high loads, it is theoretically possible that NM learns of
a changed file too late. To be sure, we should probably call
to 'nmcli connection load' synchronously, just before running
'ifup' on a given device.
NetworkManager is asked to reload its configuration during
the %post stage of installation. If it is not running,
systemctl simply exits with exit code 130 and doesn't try
to start it.
Change-Id: I3eb80b3a280abd72c7084860467aca12907d0477
Bug-Url: https://bugzilla.redhat.com/1304509
Signed-off-by: Ondřej Svoboda <osvob...@redhat.com>
Reviewed-on: https://gerrit.ovirt.org/56365
Continuous-Integration: Jenkins CI
Reviewed-by: Dan Kenigsberg <dan...@redhat.com>
Tested-by: Dan Kenigsberg <dan...@redhat.com>
---
M vdsm.spec.in
A vdsm/90-vdsm-monitor-connection-files.conf
M vdsm/Makefile.am
3 files changed, 22 insertions(+), 0 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Dan Kenigsberg: Verified; Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/56365
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3eb80b3a280abd72c7084860467aca12907d0477
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda <osvob...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Edward Haas <edwa...@redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabi...@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda <osvob...@redhat.com>
Gerrit-Reviewer: Petr Horáček <phora...@redhat.com>
Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org>
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
