Milan Zamazal has posted comments on this change. Change subject: migrations: change convergence schedule from time to iterations ......................................................................
Patch Set 4: My last comment was wrong. The patch is actually targeted at large VMs. My confusion was from misinterpreting data_remaining value. It contains the amount of memory to copy in the current iteration not counting memory already copied and dirtied in the meantime (so it's not a total amount of dirty memory, it's just a pointer to current iteration progress). Then this algorithm should work fine indeed. -- To view, visit https://gerrit.ovirt.org/56558 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6f87c954031842c35c99888c228a34ec7f19d800 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek <mskri...@redhat.com> Gerrit-Reviewer: Milan Zamazal <mzama...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: No _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
