Piotr Kliczewski has posted comments on this change. Change subject: bridge: data verification ......................................................................
Patch Set 28: (1 comment) https://gerrit.ovirt.org/#/c/53919/28/lib/api/schemaapi.py File lib/api/schemaapi.py: Line 160: method_name)) Line 161: continue Line 162: self._verify_type(param, arg, class_name, method_name) Line 163: except Exception as e: Line 164: if isinstance(e, JsonRpcInvalidParamsError): > any reason for not using the pythonic We could have one more block for this specific Error and reraise it. Will fix. Line 165: raise Line 166: self._report_inconsistency('Unexpected issue with request type' Line 167: ' verification for %s.%s' Line 168: % (class_name, method_name)) -- To view, visit https://gerrit.ovirt.org/53919 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id24a5e078fa92e4129d37a47593c7a167e78712e Gerrit-PatchSet: 28 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
