Yaniv Bronhaim has posted comments on this change. Change subject: bridge: data verification ......................................................................
Patch Set 30: (2 comments) https://gerrit.ovirt.org/#/c/53919/30/lib/api/schemaapi.py File lib/api/schemaapi.py: Line 36: 'uint': lambda value: isinstance(value, int) and value >= 0} Line 37: TYPE_KEYS = list(PRIMITIVE_TYPES.keys()) Line 38: Line 39: Line 40: default_values = {'{}': {}, default_values should be also ALL CAPS I guess.. Line 41: '()': ()} Line 42: Line 43: Line 44: class SchemaNotFound(Exception): https://gerrit.ovirt.org/#/c/53919/30/lib/yajsonrpc/__init__.py File lib/yajsonrpc/__init__.py: Line 17: from functools import partial Line 18: try: Line 19: from Queue import Queue Line 20: except ImportError: # py3 Line 21: from queue import Queue can you move it to vdsm.compat ? Line 22: from weakref import ref Line 23: from threading import Lock, Event Line 24: Line 25: from vdsm.compat import json -- To view, visit https://gerrit.ovirt.org/53919 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id24a5e078fa92e4129d37a47593c7a167e78712e Gerrit-PatchSet: 30 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
