Martin Polednik has posted comments on this change. Change subject: v2v: Detect VM with snapshots ......................................................................
Patch Set 10: Code-Review+1 (2 comments) minor Qs/comments inside https://gerrit.ovirt.org/#/c/56574/10/lib/api/vdsm-api.yml File lib/api/vdsm-api.yml: PS10, Line 963: Whether the VM has snapshots or not. I'd prefer different wording, something like (took from below)~ Information on whether VM includes snapshot. https://gerrit.ovirt.org/#/c/56574/10/lib/vdsm/v2v.py File lib/vdsm/v2v.py: PS10, Line 909: ') Why don't we care about exc_info? -- To view, visit https://gerrit.ovirt.org/56574 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9aa4de2faff92625cd0de8e3ae2a10a2d58aa823 Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Tomas Golembiovsky <tgole...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <mpoled...@redhat.com> Gerrit-Reviewer: Milan Zamazal <mzama...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Shahar Havivi <shav...@redhat.com> Gerrit-Reviewer: Tomas Golembiovsky <tgole...@redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeen...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
