Nir Soffer has posted comments on this change. Change subject: v2v: Detect VM with snapshots ......................................................................
Patch Set 10: (1 comment) https://gerrit.ovirt.org/#/c/56574/10/lib/vdsm/v2v.py File lib/vdsm/v2v.py: Line 899: Line 900: Line 901: def _add_snapshot_info(conn, vm, params): Line 902: # Snapshot related API is not yet implemented in the libvirt's Xen driver Line 903: if conn.getType() == 'Xen': > not a fan of this but I can't really think of a better alternative. let it How about trying to acess libvirt, and catching the libvirt.VIR_ERR_NO_SUPPORT error? We use this for listAllDomains() and blockCopy() Line 904: return Line 905: Line 906: try: Line 907: ret = vm.hasCurrentSnapshot() -- To view, visit https://gerrit.ovirt.org/56574 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9aa4de2faff92625cd0de8e3ae2a10a2d58aa823 Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Tomas Golembiovsky <tgole...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <mpoled...@redhat.com> Gerrit-Reviewer: Milan Zamazal <mzama...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Shahar Havivi <shav...@redhat.com> Gerrit-Reviewer: Tomas Golembiovsky <tgole...@redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeen...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
