Francesco Romani has posted comments on this change. Change subject: virt: graphics: enforce spice default mode ......................................................................
Patch Set 4: (1 comment) https://gerrit.ovirt.org/#/c/56746/3/vdsm/virt/vmdevices/graphics.py File vdsm/virt/vmdevices/graphics.py: Line 132: if not utils.tobool(self.specParams.get('fileTransferEnable', True)): Line 133: filetransfer = vmxml.Element('filetransfer', enable='no') Line 134: graphics.appendChild(filetransfer) Line 135: Line 136: # This list could be dropped in 4.1. We should keep only > might be worth adding that this can be dropped in 4.1 then as there is no r Done Line 137: # the default mode, which is both simpler and safer. Line 138: if (self.device == 'spice' and Line 139: 'spiceSecureChannels' in self.specParams): Line 140: for chan in self._getSpiceChannels(): -- To view, visit https://gerrit.ovirt.org/56746 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I169e7c4a76717dda8aeacbdb20ee031f453ed4fa Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <mpoled...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com> Gerrit-Reviewer: Milan Zamazal <mzama...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
