Dan Kenigsberg has submitted this change and it was merged. Change subject: virt: graphics: enforce spice default mode ......................................................................
virt: graphics: enforce spice default mode Libvirt grants one additional protection layer for spice channels, using the `defaultMode' attribute for the graphics device. As the name hints, this allows us to select the default mode (secure, insecure) for SPICE channels, if not explicitely specified. This patch makes Vdsm use this attribute for improved security, depending on the 'ssl' config value. Change-Id: I169e7c4a76717dda8aeacbdb20ee031f453ed4fa Backport-To: 3.6 Signed-off-by: Francesco Romani <from...@redhat.com> Reviewed-on: https://gerrit.ovirt.org/56746 Reviewed-by: Michal Skrivanek <michal.skriva...@redhat.com> Reviewed-by: Milan Zamazal <mzama...@redhat.com> Reviewed-by: Martin Polednik <mpoled...@redhat.com> Continuous-Integration: Jenkins CI Reviewed-by: Dan Kenigsberg <dan...@redhat.com> --- M tests/deviceTests.py M vdsm/virt/vmdevices/graphics.py 2 files changed, 18 insertions(+), 6 deletions(-) Approvals: Jenkins CI: Passed CI tests Dan Kenigsberg: Looks good to me, approved Francesco Romani: Verified Michal Skrivanek: Looks good to me, but someone else must approve Martin Polednik: Looks good to me, but someone else must approve Milan Zamazal: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/56746 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I169e7c4a76717dda8aeacbdb20ee031f453ed4fa Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <mpoled...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com> Gerrit-Reviewer: Milan Zamazal <mzama...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
