Liron Aravot has posted comments on this change. Change subject: sp: race in domains upgrade prevents further pool upgrades ......................................................................
Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/57315/2/vdsm/storage/sp.py File vdsm/storage/sp.py: Line 460 Line 461 Line 462 Line 463 Line 464 > list[:] is atomic, we cannot have any race. Generally i'm not in favor of depending on implementation details - who knows what will be in a further version? is something in the specification guarantees us its safe? if we write code for multi threaded env i'd prefer to write it correctly and not rely on impl details. if you both are strongly against - i'll change it, but i'd be happy if you reconsidered. -- To view, visit https://gerrit.ovirt.org/57315 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie384c63315214786dc62f2b4998002320e314d30 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
