Nir Soffer has posted comments on this change.

Change subject: sp: race in domains upgrade prevents further pool upgrades
......................................................................


Patch Set 4:

(1 comment)

https://gerrit.ovirt.org/#/c/57315/4/vdsm/storage/sp.py
File vdsm/storage/sp.py:

Line 462:                 self._upgradeCallback)
Line 463:             self.log.debug("Running initial domain upgrade threads")
Line 464:             # We need to copy the list as the domain monitor 
registered callback
Line 465:             # and the initiated update threads may modify the list 
while we
Line 466:             # iterate over it
Can you link to the bug here?
Line 467:             for sdUUID in self._domainsToUpgrade[:]:
Line 468:                 concurrent.thread(self._upgradeCallback,
Line 469:                                   args=(sdUUID, True),
Line 470:                                   kwargs={"__securityOverride": True},


-- 
To view, visit https://gerrit.ovirt.org/57315
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie384c63315214786dc62f2b4998002320e314d30
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <[email protected]>
Gerrit-Reviewer: Adam Litke <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <[email protected]>
Gerrit-Reviewer: Nir Soffer <[email protected]>
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to