Nir Soffer has posted comments on this change. Change subject: v2v: Detect VM with snapshots ......................................................................
Patch Set 10: (1 comment) https://gerrit.ovirt.org/#/c/56574/10/lib/vdsm/v2v.py File lib/vdsm/v2v.py: Line 899: Line 900: Line 901: def _add_snapshot_info(conn, vm, params): Line 902: # Snapshot related API is not yet implemented in the libvirt's Xen driver Line 903: if conn.getType() == 'Xen': > Yes, I know. For listAllDomains() it makes sense to catch the exception, be It is not about the possibility of implementing it in the future, but about not making assumptions about libvirt when we can use a generic way to handle unsupported apis. Francesco, what do you think? Line 904: return Line 905: Line 906: try: Line 907: ret = vm.hasCurrentSnapshot() -- To view, visit https://gerrit.ovirt.org/56574 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9aa4de2faff92625cd0de8e3ae2a10a2d58aa823 Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Tomas Golembiovsky <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <[email protected]> Gerrit-Reviewer: Milan Zamazal <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Shahar Havivi <[email protected]> Gerrit-Reviewer: Tomas Golembiovsky <[email protected]> Gerrit-Reviewer: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
