Milan Zamazal has posted comments on this change. Change subject: vm: devices: fix behaviour with balloon model=none ......................................................................
Patch Set 1: To clarify: We must be careful about balloon devices because if libvirt doesn't find one in the domain XML then it creates one. We must explicitly pass model='none' device to disable balloon devices. But in Balloon.update_device_info, there is probably nothing useful we can retrieve from a none device, so we can skip it (for simplicity, otherwise there is nothing wrong with your change). -- To view, visit https://gerrit.ovirt.org/54440 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iab96f47118148a67135286a3a9b1998840efce18 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <mpoled...@redhat.com> Gerrit-Reviewer: Milan Zamazal <mzama...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: No _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches