Milan Zamazal has posted comments on this change. Change subject: vm: devices: fix behaviour with balloon model=none ......................................................................
Patch Set 2: (2 comments) https://gerrit.ovirt.org/#/c/54440/2//COMMIT_MSG Commit Message: Line 5: CommitDate: 2016-05-17 14:35:00 +0200 Line 6: Line 7: vm: devices: fix behaviour with balloon model=none Line 8: Line 9: TODO: learn why this doesn't happen in the creation path. Because it (for me) happens only when libvirtd gets restarted during VM life. Line 10: Line 11: In the recovery flow, should Vdsm recover a VM configured Line 12: with balloon device model=none Line 13: Line 8: Line 9: TODO: learn why this doesn't happen in the creation path. Line 10: Line 11: In the recovery flow, should Vdsm recover a VM configured Line 12: with balloon device model=none Again, probably only if libvirtd is restarted or other problem happens with libvirtd/QEMU. Line 13: Line 14: <memballoon model='none'/> Line 15: Line 16: The recovery fails with -- To view, visit https://gerrit.ovirt.org/54440 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iab96f47118148a67135286a3a9b1998840efce18 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <mpoled...@redhat.com> Gerrit-Reviewer: Milan Zamazal <mzama...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
