Piotr Kliczewski has posted comments on this change. Change subject: bridge: data verification ......................................................................
Patch Set 33: (2 comments) https://gerrit.ovirt.org/#/c/53919/33/lib/vdsm/compat.py File lib/vdsm/compat.py: Line 54: from vdsm.common.contextlib import suppress Line 55: suppress # yep, this is needed twice. Line 56: Line 57: try: Line 58: from Queue import Queue > no need to reinvent six.moves.queue Done Line 59: except ImportError: # py3 Line 60: from queue import Queue https://gerrit.ovirt.org/#/c/53919/33/lib/yajsonrpc/__init__.py File lib/yajsonrpc/__init__.py: Line 14 Line 15 Line 16 Line 17 Line 18 > this change belongs to a different patch We can use six here so we do not need to have different patch. -- To view, visit https://gerrit.ovirt.org/53919 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id24a5e078fa92e4129d37a47593c7a167e78712e Gerrit-PatchSet: 33 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
