Dan Kenigsberg has submitted this change and it was merged.

Change subject: Fix race in fileUtils.createdir().
......................................................................


Fix race in fileUtils.createdir().

Checking dir inexistence and creating it afterwards is racy.

This version creates the target dir, and if it already existed
check if has the requested permissions.

Change-Id: Iac856c219a08fa0303e5da1d04f4f6b8e17e07a3
Bug-Id: https://bugzilla.redhat.com/show_bug.cgi?id=838547
Signed-off-by: Eduardo <[email protected]>
---
M vdsm/storage/fileUtils.py
1 file changed, 20 insertions(+), 4 deletions(-)

Approvals:
  Adam Litke: Looks good to me, but someone else must approve
  Yeela Kaplan: Looks good to me, but someone else must approve
  Yaniv Bronhaim: Looks good to me, but someone else must approve
  Dan Kenigsberg: Verified; Looks good to me, approved
  Zhou Zheng Sheng: Looks good to me, but someone else must approve


--
To view, visit http://gerrit.ovirt.org/8732
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iac856c219a08fa0303e5da1d04f4f6b8e17e07a3
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <[email protected]>
Gerrit-Reviewer: Adam Litke <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Eduardo <[email protected]>
Gerrit-Reviewer: Shu Ming <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: Yeela Kaplan <[email protected]>
Gerrit-Reviewer: Zhou Zheng Sheng <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to