Freddy Rolland has posted comments on this change. Change subject: Move volume type constants to constants module ......................................................................
Patch Set 1: (4 comments) https://gerrit.ovirt.org/#/c/57581/1/lib/vdsm/storage/constants.py File lib/vdsm/storage/constants.py: PS1, Line 83: fmt2str volfmt2str ? PS1, Line 87: type2name It seems a little too vague now it is in constants. Maybe voltype2name ? PS1, Line 94: name2type name2voltype ? https://gerrit.ovirt.org/#/c/57581/1/tests/blockVolumeTests.py File tests/blockVolumeTests.py: PS1, Line 23: storage_constants Why not "as sc" ? -- To view, visit https://gerrit.ovirt.org/57581 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6a8db6de344d85029cb8fa2da302c88f4d605991 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Ala Hino <ah...@redhat.com> Gerrit-Reviewer: Freddy Rolland <froll...@redhat.com> Gerrit-Reviewer: Idan Shaby <ish...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
