Nir Soffer has posted comments on this change. Change subject: Move volume type constants to constants module ......................................................................
Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/57581/1/lib/vdsm/storage/constants.py File lib/vdsm/storage/constants.py: Line 79: Line 80: BLANK_UUID = "00000000-0000-0000-0000-000000000000" Line 81: Line 82: Line 83: def fmt2str(format): > volfmt2str ? Let keep such improvement for later patches, we like to limit the amount of changes here. Adam, do we really need to move the functions here? having functions in constants module is unusual. Line 84: return FMT2STR[format] Line 85: Line 86: Line 87: def type2name(volType): -- To view, visit https://gerrit.ovirt.org/57581 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6a8db6de344d85029cb8fa2da302c88f4d605991 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Ala Hino <ah...@redhat.com> Gerrit-Reviewer: Freddy Rolland <froll...@redhat.com> Gerrit-Reviewer: Idan Shaby <ish...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
