Fabian Deutsch has posted comments on this change. Change subject: vdsm: adding handling for NGN in osinfo.py ......................................................................
Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/57620/3/lib/vdsm/osinfo.py File lib/vdsm/osinfo.py: Line 92: @utils.memoized Line 93: def _release_name(): Line 94: if os.path.exists('/etc/rhev-hypervisor-release'): Line 95: return OSName.RHEVH Line 96: elif os.path.exists('/etc/os-release'): > I'm just wondering if /etc/os-release file is not present in any other OS. /etc/os-release ie present in many distros. Fedora, CentOS, RHEL, Ubuntu, SuSE, etc. And please use /etc/os-release - this is the only file we guarantee. The location of the file "behind it" /usr/lib/… is a Node internal, nothing somenoe else should be using. Btw - Why is special handling for NGn done here? The same mechanism/logic should work for centos, rhel, fedora and node! Line 97: return OSName.OVIRT_NGN Line 98: elif glob.glob('/etc/ovirt-node-*-release'): Line 99: return OSName.OVIRT Line 100: elif os.path.exists('/etc/fedora-release'): -- To view, visit https://gerrit.ovirt.org/57620 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I17337643cd4e986c09b07137d80da3555161ee70 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eli Mesika <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Fabian Deutsch <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
