Martin Peřina has posted comments on this change. Change subject: vdsm: adding handling for NGN in osinfo.py ......................................................................
Patch Set 5: (1 comment) https://gerrit.ovirt.org/#/c/57620/5/lib/vdsm/osinfo.py File lib/vdsm/osinfo.py: Line 147: osname = _release_name() Line 148: try: Line 149: if osname == OSName.RHEVH or osname == OSName.OVIRT: Line 150: version, release_name = _parse_node_version('/etc/default/version') Line 151: elif osname == OSName.OVIRT_NGN: > I am not sure why there is now a differentiation. Fabian, I don't want to change the logic of the method now, when today is the feature freeze. We can improve it for 4.1, but for 4.0 we just need to detect NGN using existing logic. Can we agree on following? 1. Modify _release_name() method to be able to detect the host is NGN (testing presence of some file seem to me like a good idea). So what file can we use to detect host is NGN? 2. Modify version() method if NGN is detected to fill in some reasonable values. So which value do you suggest to use? Line 152: osname, version, release_name = _parse_ngn_version('/etc/os-release') Line 153: elif osname == OSName.DEBIAN: Line 154: version = linecache.getline('/etc/debian_version', 1).strip("\n") Line 155: release_name = "" # Debian just has a version entry -- To view, visit https://gerrit.ovirt.org/57620 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I17337643cd4e986c09b07137d80da3555161ee70 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eli Mesika <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Fabian Deutsch <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
