Freddy Rolland has posted comments on this change.

Change subject: Move Volume MD fields to storage constants
......................................................................


Patch Set 3: Code-Review-1

(1 comment)

Need to fix import in previous patch, needed here

https://gerrit.ovirt.org/#/c/57582/3/vdsm/storage/volume.py
File vdsm/storage/volume.py:

Line 38: import task
Line 39: import resourceFactories
Line 40: import resourceManager as rm
Line 41: rmanager = rm.ResourceManager.getInstance()
Line 42: 
Missing import ?
from vdsm.storage import constants as sc
Line 43: 
Line 44: DOMAIN_MNT_POINT = 'mnt'
Line 45: 
Line 46: log = logging.getLogger('Storage.Volume')


-- 
To view, visit https://gerrit.ovirt.org/57582
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib0b6f5a6c7fdf28da85aa8f8eeeb111a59f0af5d
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <ali...@redhat.com>
Gerrit-Reviewer: Adam Litke <ali...@redhat.com>
Gerrit-Reviewer: Ala Hino <ah...@redhat.com>
Gerrit-Reviewer: Freddy Rolland <froll...@redhat.com>
Gerrit-Reviewer: Idan Shaby <ish...@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com>
Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org>
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to