Nir Soffer has submitted this change and it was merged. Change subject: Move Volume MD fields to storage constants ......................................................................
Move Volume MD fields to storage constants volume.py is imported by many other modules for its constants. This can cause circular dependencies. Move the constants to vdsm.storage.constants which will reduce the need for modules to import volume.py. This patch moves the constants related to the volume metadata field names. Change-Id: Ib0b6f5a6c7fdf28da85aa8f8eeeb111a59f0af5d Signed-off-by: Adam Litke <ali...@redhat.com> Reviewed-on: https://gerrit.ovirt.org/57582 Reviewed-by: Nir Soffer <nsof...@redhat.com> Reviewed-by: Ala Hino <ah...@redhat.com> Reviewed-by: Freddy Rolland <froll...@redhat.com> Continuous-Integration: Jenkins CI --- M lib/vdsm/storage/constants.py M tests/storage_volume_metadata_test.py M vdsm/storage/blockVolume.py M vdsm/storage/fileVolume.py M vdsm/storage/imageRepository/formatConverter.py M vdsm/storage/volume.py 6 files changed, 151 insertions(+), 152 deletions(-) Approvals: Nir Soffer: Looks good to me, approved Adam Litke: Verified Jenkins CI: Passed CI tests Freddy Rolland: Looks good to me, but someone else must approve Ala Hino: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/57582 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib0b6f5a6c7fdf28da85aa8f8eeeb111a59f0af5d Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Ala Hino <ah...@redhat.com> Gerrit-Reviewer: Freddy Rolland <froll...@redhat.com> Gerrit-Reviewer: Idan Shaby <ish...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
