Freddy Rolland has posted comments on this change. Change subject: Move volume type constants to constants module ......................................................................
Patch Set 3: (2 comments) https://gerrit.ovirt.org/#/c/57581/3/vdsm/storage/blockSD.py File vdsm/storage/blockSD.py: Line 54: from resourceFactories import LVM_ACTIVATION_NAMESPACE Line 55: import iscsi Line 56: from storage_mailbox import MAILBOX_SIZE Line 57: import resourceManager as rm Line 58: > Missing import ? Ignore this, I missed it. Line 59: STORAGE_DOMAIN_TAG = "RHAT_storage_domain" Line 60: STORAGE_UNREADY_DOMAIN_TAG = STORAGE_DOMAIN_TAG + "_UNREADY" Line 61: Line 62: MASTERLV = "master" https://gerrit.ovirt.org/#/c/57581/3/vdsm/storage/volume.py File vdsm/storage/volume.py: Line 38: import task Line 39: import resourceFactories Line 40: import resourceManager as rm Line 41: rmanager = rm.ResourceManager.getInstance() Line 42: > Missing import ? Ignore this, I missed it. Line 43: Line 44: DOMAIN_MNT_POINT = 'mnt' Line 45: Line 46: # Volume meta data fields -- To view, visit https://gerrit.ovirt.org/57581 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6a8db6de344d85029cb8fa2da302c88f4d605991 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Ala Hino <ah...@redhat.com> Gerrit-Reviewer: Freddy Rolland <froll...@redhat.com> Gerrit-Reviewer: Idan Shaby <ish...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
