Nir Soffer has submitted this change and it was merged. Change subject: Move volume type constants to constants module ......................................................................
Move volume type constants to constants module volume.py is imported by many other modules for its constants. This can cause circular dependencies. Move the constants to vdsm.storage.constants which will reduce the need for modules to import volume.py. This patch moves the constants related to identifying and describing volume types. Change-Id: I6a8db6de344d85029cb8fa2da302c88f4d605991 Signed-off-by: Adam Litke <ali...@redhat.com> Reviewed-on: https://gerrit.ovirt.org/57581 Reviewed-by: Nir Soffer <nsof...@redhat.com> Reviewed-by: Ala Hino <ah...@redhat.com> Reviewed-by: Freddy Rolland <froll...@redhat.com> Continuous-Integration: Jenkins CI --- M lib/vdsm/storage/constants.py M tests/blockVolumeTests.py M tests/storage_volume_artifacts_test.py M tests/storage_volume_metadata_test.py M tests/storagetestlib.py M tests/storagetestlibTests.py M vdsm/API.py M vdsm/storage/blockSD.py M vdsm/storage/blockVolume.py M vdsm/storage/fileVolume.py M vdsm/storage/hsm.py M vdsm/storage/image.py M vdsm/storage/imageRepository/formatConverter.py M vdsm/storage/sd.py M vdsm/storage/sdm/api/create_volume.py M vdsm/storage/sdm/volume_artifacts.py M vdsm/storage/sp.py M vdsm/storage/volume.py 18 files changed, 331 insertions(+), 328 deletions(-) Approvals: Nir Soffer: Looks good to me, approved Adam Litke: Verified Jenkins CI: Passed CI tests Freddy Rolland: Looks good to me, but someone else must approve Ala Hino: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/57581 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6a8db6de344d85029cb8fa2da302c88f4d605991 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Ala Hino <ah...@redhat.com> Gerrit-Reviewer: Freddy Rolland <froll...@redhat.com> Gerrit-Reviewer: Idan Shaby <ish...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
