Milan Zamazal has posted comments on this change. Change subject: build: Make sure run_tests*.sh scripts are executable ......................................................................
Patch Set 5: (1 comment) https://gerrit.ovirt.org/#/c/55949/4/build-aux/Makefile.subs File build-aux/Makefile.subs: Line 39: Line 40: CONFIGSUBST = $(top_builddir)/config.status --file=- Line 41: Line 42: %: %.in Line 43: @echo " SED $@"; $(PATHSUBST) $< |$(CONFIGSUBST) >$@ > I have found out why it worked for Milan. Automake generated Makefiles have Thank you, Tomáš, for explaining those tricky issues! Yaniv, your make_executables rule works, but it must be invoked some way, which may be a problem and is not going to simplify things I guess. Since Tomáš has confirmed single colon works, we can leave it here and we can consider his suggestion of switching to double colon in a separate patch. Line 44: @if expr "$@" : ".*\\.sh" >/dev/null ; then \ Line 45: chmod a+x "$@" ; \ -- To view, visit https://gerrit.ovirt.org/55949 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibc1e3dc8ace7f69801b765262352903020cc8aef Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Milan Zamazal <mzama...@redhat.com> Gerrit-Reviewer: Irit Goihman <igoih...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Milan Zamazal <mzama...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Tomas Golembiovsky <tgole...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
