Milan Zamazal has posted comments on this change. Change subject: build: Make sure run_tests*.sh scripts are executable ......................................................................
Patch Set 5: (1 comment) https://gerrit.ovirt.org/#/c/55949/5/build-aux/Makefile.subs File build-aux/Makefile.subs: Line 22: Line 23: # Reference: Line 24: # http://www.gnu.org/software/automake/manual/html_node/Scripts.html Line 25: PATHSUBST = sed \ Line 26: -e "s,[@]top_srcdir[@],$(top_srcdir),g" \ > Yes and no. If we don't replace top_srcdir with the path provided in the Ma We had exactly that problem in former versions of this patch. Tomáš was kind to provide this line as a solution and now the patch works fine. So it is very related. :-) Line 27: -e "s,[@]BACKUPDIR[@],$(vdsmbackupdir),g" \ Line 28: -e "s,[@]BINDIR[@],$(bindir),g" \ Line 29: -e "s,[@]CONFDIR[@],$(vdsmconfdir),g" \ Line 30: -e "s,[@]HOOKSDIR[@],$(vdsmhooksdir),g" \ -- To view, visit https://gerrit.ovirt.org/55949 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibc1e3dc8ace7f69801b765262352903020cc8aef Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Milan Zamazal <mzama...@redhat.com> Gerrit-Reviewer: Irit Goihman <igoih...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Milan Zamazal <mzama...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Tomas Golembiovsky <tgole...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org