Edward Haas has posted comments on this change. Change subject: ovs: edit bond mode ......................................................................
Patch Set 9: (1 comment) Just one nit https://gerrit.ovirt.org/#/c/58437/9/lib/vdsm/network/ovs/switch.py File lib/vdsm/network/ovs/switch.py: PS9, Line 228: bond_detect_mode = 'carrier' : bond_miimon_interval = None : if miimon is not None: : bond_detect_mode = 'miimon' : bond_miimon_interval = miimon if - else seems more appropriate. if miimon is None: ... else: -- To view, visit https://gerrit.ovirt.org/58437 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9009933445c8bf162b236a2f9081e796d5f9272f Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Edward Haas <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/admin/lists/[email protected]
